Support Scatter struct_scalar
#8630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CMake
isVoid
added
feature request
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8630 +/- ##
===============================================
Coverage ? 10.64%
===============================================
Files ? 109
Lines ? 18656
Branches ? 0
===============================================
Hits ? 1985
Misses ? 16671
Partials ? 0 Continue to review full report at Codecov.
|
codereport
suggested changes
Jul 5, 2021
Co-authored-by: Conor Hoekstra <[email protected]>
|
rerun tests |
codereport
approved these changes
Jul 7, 2021
|
rerun tests |
…scatter_struct_scalar
hyperbolic2346
approved these changes
Jul 8, 2021
gerashegalov
approved these changes
Jul 8, 2021
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 20, 2021
Uses scalar-vector-based scatter API to provide support for copy_if_else involving scalar columns. Other changes: - removes some dead code - refactoring into overloaded functions Closes #8361, depends on #8630, #8666 Authors: - Gera Shegalov (https://github.com/gerashegalov) Approvers: - https://github.com/nvdbaranec - MithunR (https://github.com/mythrocks) URL: #8588
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #8558
This PR adds support for scattering struct scalars.
Implementation notes:
Current implementation is based on copying the row data from each field as a new scalar and recursively calls scalar scattering on each field. There maybe an optimization on eliminating such copy. But will require extra scaffolding/scatter machinery.
Minor aspects of this PR:
column_scalar_scattererto includescatter_scalar_bitmask_inplacein each level of dispatch. This is required because scalar scattering can be nested.count_set_bitandcount_unset_bitdetail APIsdetail::get_element