Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JNI support for capitalize [skip ci] #8624

Merged
merged 3 commits into from
Jul 2, 2021

Conversation

firestarman
Copy link
Contributor

Add JNI for the string operator capitalize.

Signed-off-by: Firestarman [email protected]

Signed-off-by: Firestarman <[email protected]>
@firestarman firestarman added feature request New feature or request 2 - In Progress Currently a work in progress 4 - Needs cuDF (Java) Reviewer non-breaking Non-breaking change labels Jun 29, 2021
@firestarman firestarman self-assigned this Jun 29, 2021
@github-actions github-actions bot added the Java Affects Java cuDF API. label Jun 29, 2021
@firestarman
Copy link
Contributor Author

This PR depends on #8620 , so it is draft now.

java/src/main/java/ai/rapids/cudf/ColumnView.java Outdated Show resolved Hide resolved
java/src/main/native/src/ColumnViewJni.cpp Outdated Show resolved Hide resolved
Signed-off-by: Firestarman <[email protected]>
@firestarman firestarman marked this pull request as ready for review July 2, 2021 03:14
@firestarman firestarman requested a review from a team as a code owner July 2, 2021 03:14
@firestarman firestarman added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 2 - In Progress Currently a work in progress labels Jul 2, 2021
@firestarman
Copy link
Contributor Author

#8620 was merged, verify this PR locally and all is fine. Will merge this.

@firestarman
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit fba09e6 into rapidsai:branch-21.08 Jul 2, 2021
@firestarman firestarman deleted the capitalize branch July 2, 2021 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants