Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate **kwargs through to as_*_column methods #8618

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Propagate **kwargs through to as_*_column methods #8618

merged 2 commits into from
Jun 29, 2021

Conversation

shwina
Copy link
Contributor

@shwina shwina commented Jun 28, 2021

Fixes #8616

@shwina shwina requested a review from a team as a code owner June 28, 2021 16:26
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jun 28, 2021
@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change labels Jun 28, 2021
@shwina
Copy link
Contributor Author

shwina commented Jun 28, 2021

@gpucibot merge

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jun 28, 2021
@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@468c573). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head a91e027 differs from pull request most recent head c2d0096. Consider uploading reports for the commit c2d0096 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8618   +/-   ##
===============================================
  Coverage                ?   83.00%           
===============================================
  Files                   ?      109           
  Lines                   ?    18231           
  Branches                ?        0           
===============================================
  Hits                    ?    15132           
  Misses                  ?     3099           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 468c573...c2d0096. Read the comment docs.

@shwina
Copy link
Contributor Author

shwina commented Jun 28, 2021

rerun tests

@rapids-bot rapids-bot bot merged commit ea82bf4 into rapidsai:branch-21.08 Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@cwharris cwharris Awaiting requested review from cwharris

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] dask_cudf and cudf not able to cast to str dtype if using dict
3 participants
@shwina @galipremsagar @brandon-b-miller