Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListColumn __setitem__ #8606

Merged
merged 32 commits into from
Jun 30, 2021
Merged

ListColumn __setitem__ #8606

merged 32 commits into from
Jun 30, 2021

Conversation

brandon-b-miller
Copy link
Contributor

Closes #8553
based on #8459

brandon-b-miller and others added 28 commits June 8, 2021 07:57
@brandon-b-miller
impl
d5059ee
@brandon-b-miller
fix bug
3c47ab1
@brandon-b-miller
remove test code
6b480ac
@brandon-b-miller
add tests
df480d6
@brandon-b-miller
merge 21.08
d1b1a41
@brandon-b-miller
style fix
26867d8
@brandon-b-miller
merge 21.08
3fd5ed5
@brandon-b-miller
use cudf.NA in tests
f925153
@brandon-b-miller
update with changes from PR 8442
8fc0fb1
@brandon-b-miller
style fixes
fdf8b16
@brandon-b-miller
supporting NA scalars
dff6f86
@brandon-b-miller
add tests
e0eab01
@brandon-b-miller
style
62595cb
@brandon-b-miller @isVoid
Update python/cudf/cudf/core/column/column.py
19d1691 
Co-authored-by: Michael Wang <[email protected]>
@brandon-b-miller
initial progress, going back to look at scalar construction
ac184b3
@brandon-b-miller
fix non nested case
99c49d3
@brandon-b-miller
Merge branch 'fea-construct-listscalar-from-host' of github.com:brand…
6cf8796 
…on-b-miller/cudf into fea-construct-listscalar-from-host
@brandon-b-miller
style
6fdb931
@brandon-b-miller
Merge branch 'branch-21.08' into fea-construct-listscalar-from-host
cff4b79
@brandon-b-miller
merge fea-construct-listscalar-from-host
503bf95
@brandon-b-miller
fix merge
1e18e34
@brandon-b-miller
listcolumn updates
a6165c6
@brandon-b-miller
stale breakpoint
2b4f18a
@brandon-b-miller
NA begets NA on scalar construction, cant set yet though
8c9a182
@brandon-b-miller
refactor as_device_scalar
2869846
@brandon-b-miller
fix NA cases and add tests
cfb9d97
@brandon-b-miller
cleanup
33eafb2
@brandon-b-miller
cleanup logic
2ce60cb
@brandon-b-miller brandon-b-miller added feature request New feature or request 2 - In Progress Currently a work in progress labels Jun 24, 2021
@brandon-b-miller brandon-b-miller added Python Affects Python cuDF API. Cython non-breaking Non-breaking change labels Jun 24, 2021
@brandon-b-miller brandon-b-miller requested a review from a team as a code owner June 24, 2021 21:41
shwina
shwina approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@galipremsagar
Copy link
Contributor

@brandon-b-miller Looks like there are some pytest failures related to this PR, could you take a look at it when you get time?

@codecov
Copy link

codecov bot commented Jun 28, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@5f11b76). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 2593ef9 differs from pull request most recent head 8f7192c. Consider uploading reports for the commit 8f7192c to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8606   +/-   ##
===============================================
  Coverage                ?   83.01%           
===============================================
  Files                   ?      109           
  Lines                   ?    18247           
  Branches                ?        0           
===============================================
  Hits                    ?    15147           
  Misses                  ?     3100           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f11b76...8f7192c. Read the comment docs.

@brandon-b-miller
Copy link
Contributor Author

rerun tests

3 similar comments
@brandon-b-miller
Copy link
Contributor Author

rerun tests

@brandon-b-miller
Copy link
Contributor Author

rerun tests

@galipremsagar
Copy link
Contributor

rerun tests

@brandon-b-miller brandon-b-miller added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 2 - In Progress Currently a work in progress labels Jun 30, 2021
@brandon-b-miller
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5884b95 into rapidsai:branch-21.08 Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@shwina shwina shwina approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] ListColumn setitem
3 participants
@brandon-b-miller @galipremsagar @shwina