Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize libcudf basic example CMakeFile; updates CI build tests #8568

Merged
merged 3 commits into from
Jun 22, 2021

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Jun 19, 2021

Follow up of #7671

This PR addresses review comments from #7671 (comment), modernizing the CMakeFile in libcudf basic example.

This PR also updates build tests for examples to make sure they are tested after both regular/project flash code path.

@isVoid isVoid requested review from a team as code owners June 19, 2021 21:01
@isVoid isVoid self-assigned this Jun 19, 2021
@github-actions github-actions bot added CMake CMake build issue gpuCI libcudf Affects libcudf (C++/CUDA) code. labels Jun 19, 2021
@isVoid isVoid added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 19, 2021
@codecov
Copy link

codecov bot commented Jun 19, 2021

Codecov Report

Merging #8568 (9fad262) into branch-21.08 (1de662f) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 9fad262 differs from pull request most recent head 34958d7. Consider uploading reports for the commit 34958d7 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.08    #8568      +/-   ##
================================================
+ Coverage         82.57%   82.62%   +0.04%     
================================================
  Files               109      109              
  Lines             17817    17859      +42     
================================================
+ Hits              14713    14756      +43     
+ Misses             3104     3103       -1     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/lists.py 86.53% <100.00%> (+0.26%) ⬆️
python/cudf/cudf/core/dtypes.py 93.98% <100.00%> (+1.03%) ⬆️
python/cudf/cudf/utils/dtypes.py 82.87% <0.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1de662f...34958d7. Read the comment docs.

@isVoid isVoid changed the title Modernize libcudf basic example CMakeFile Modernize libcudf basic example CMakeFile; updates CI build tests Jun 21, 2021
@harrism
Copy link
Member

harrism commented Jun 22, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 681c40e into rapidsai:branch-21.08 Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants