Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add strings::repeat_strings API that can repeat each string a different number of times #8561

Merged
merged 37 commits into from
Jul 20, 2021
Merged

Add strings::repeat_strings API that can repeat each string a different number of times #8561

merged 37 commits into from
Jul 20, 2021

Commits on Jun 18, 2021

  1. Add doxygen

    @ttnghia
    ttnghia committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    f0b5ff7 View commit details
    Browse the repository at this point in the history

  2. Finish implementation

    @ttnghia
    ttnghia committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    a61c1e7 View commit details
    Browse the repository at this point in the history

  3. Finish unit tests

    @ttnghia
    ttnghia committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    2639f9a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'branch-21.08' into repeat_strings

    @ttnghia
    ttnghia committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    dbbfbf9 View commit details
    Browse the repository at this point in the history

  5. Fix merge conflicts

    @ttnghia
    ttnghia committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    0dec873 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. Rename parameter back to input

    @ttnghia
    ttnghia committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    143f853 View commit details
    Browse the repository at this point in the history

  2. Fix typo

    @ttnghia
    ttnghia committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    b39bb06 View commit details
    Browse the repository at this point in the history

  3. Rewrite using type_dispatcher for different integer types

    @ttnghia
    ttnghia committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    ae40591 View commit details
    Browse the repository at this point in the history

  4. Fix comment typo

    @ttnghia
    ttnghia committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    8612f61 View commit details
    Browse the repository at this point in the history

  5. Remove input check for int32_t data type

    @ttnghia
    ttnghia committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    3dfec42 View commit details
    Browse the repository at this point in the history

  6. Remove bool type from the expecting types for repeat_times data type

    @ttnghia
    ttnghia committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    d230498 View commit details
    Browse the repository at this point in the history

  7. Implement overflow check for the new API, as it can't be done outside… 

    … of cudf
    @ttnghia
    ttnghia committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    f534372 View commit details
    Browse the repository at this point in the history

  8. Update doxygen

    @ttnghia
    ttnghia committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    554d20d View commit details
    Browse the repository at this point in the history

  9. Add typed tests for various types of repeat_times column

    @ttnghia
    ttnghia committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    d00ba01 View commit details
    Browse the repository at this point in the history

  10. Fix doxygen

    @ttnghia
    ttnghia committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    5b5c2a4 View commit details
    Browse the repository at this point in the history

  11. Simplify overflow checking

    @ttnghia
    ttnghia committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    d488eca View commit details
    Browse the repository at this point in the history

  12. Just re-order code

    @ttnghia
    ttnghia committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    8498fc6 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. Add a parameter to allow turning on/off overflow checking

    @ttnghia
    ttnghia committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    855a774 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2021

  1. Implement overflow checking

    @ttnghia
    ttnghia committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    e5f5db8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'branch-21.08' into repeat_strings

    @ttnghia
    ttnghia committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    50f05fd View commit details
    Browse the repository at this point in the history

  3. Redesign the API and update doxygen

    @ttnghia
    ttnghia committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    0bcf8d8 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2021

  1. Add an optional column of pre-computed output strings offsets

    @ttnghia
    ttnghia committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    c7b7c3b View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. Merge branch 'branch-21.08' into repeat_strings

    @ttnghia
    ttnghia committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    f6d7ee3 View commit details
    Browse the repository at this point in the history

  2. Finish implementation

    @ttnghia
    ttnghia committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    d22c4e5 View commit details
    Browse the repository at this point in the history

  3. Fix JNI

    @ttnghia
    ttnghia committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    6124e83 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'branch-21.08' into repeat_strings 

    # Conflicts:
#	cpp/include/cudf/strings/repeat_strings.hpp
    @ttnghia
    ttnghia committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    90517aa View commit details
    Browse the repository at this point in the history

  5. Cleanup

    @ttnghia
    ttnghia committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    7795f54 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2021

  1. Remove duplicate code

    @ttnghia
    ttnghia committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    9158e4f View commit details
    Browse the repository at this point in the history

  2. Add test for computing string output sizes that causes overflow

    @ttnghia
    ttnghia committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    5e37782 View commit details
    Browse the repository at this point in the history

  3. Fix test build error

    @ttnghia
    ttnghia committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    4dfca75 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'branch-21.08' into repeat_strings

    @ttnghia
    ttnghia committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    95cb6c0 View commit details
    Browse the repository at this point in the history

  5. Simple fix comment typo

    @ttnghia
    ttnghia committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    91c414e View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2021

  1. Address review comments, fixing doxygen and some code improvements

    @ttnghia
    ttnghia committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    00ad095 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'branch-21.08' into repeat_strings

    @ttnghia
    ttnghia committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    b7956e4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'branch-21.08' into repeat_strings

    @ttnghia
    ttnghia committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    bebb9e6 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. Cleanup header

    @ttnghia
    ttnghia committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    5c554c1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'branch-21.08' into repeat_strings 

    # Conflicts:
#	cpp/tests/strings/repeat_strings_tests.cpp
    @ttnghia
    ttnghia committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    b294f52 View commit details
    Browse the repository at this point in the history