Rename concatenate_tests.cu to .cpp #8555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
3 - Ready for Review
ttnghia
approved these changes
Jun 18, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8555 +/- ##
===============================================
Coverage ? 83.00%
===============================================
Files ? 109
Lines ? 18215
Branches ? 0
===============================================
Hits ? 15119
Misses ? 3096
Partials ? 0 Continue to review full report at Codecov.
|
harrism
requested changes
Jun 22, 2021
nvdbaranec
approved these changes
Jun 22, 2021
harrism
reviewed
Jun 23, 2021
| typed_data, h_data.data(), data_size(), cudaMemcpyHostToDevice, stream.value())); | ||
| CUDA_TRY(cudaMemcpyAsync( | ||
| typed_mask, h_mask.data(), mask_size(), cudaMemcpyHostToDevice, stream.value())); | ||
| stream.synchronize(); |
There was a problem hiding this comment.
You could have stuck with the default stream and just synced it, but this is more general. 👍
harrism
approved these changes
Jun 23, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this file can be changed to .cpp by modifying the
TypedColumnTestto build its test data in the CPU and then cudaMemcpy it to the GPU. The remain ~1000 lines did not require any updates. Only a fewlists_column_wrapperctors needed to be corrected as similar to PR #8527.