Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix __repr__ output with display.max_rows is None #8547

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

galipremsagar
Copy link
Contributor

Fixes: #6978

This PR fixes __repr__ output when display.max_rows is None, when it is None the output must have all the rows of series printed. This is already being handled as part of dataframe.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Jun 18, 2021
@galipremsagar galipremsagar self-assigned this Jun 18, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner June 18, 2021 02:59
@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@8fb1c42). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8547   +/-   ##
===============================================
  Coverage                ?   82.95%           
===============================================
  Files                   ?      109           
  Lines                   ?    18170           
  Branches                ?        0           
===============================================
  Hits                    ?    15073           
  Misses                  ?     3097           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fb1c42...24c10fc. Read the comment docs.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Jun 18, 2021
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1de662f into rapidsai:branch-21.08 Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] pd.set_option("display.max_rows", None) not supported properly
2 participants