Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small cleanup #8534

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Small cleanup #8534

merged 1 commit into from
Jun 16, 2021

Conversation

codereport
Copy link
Contributor

Small cleanup post #8422

@codereport codereport added 3 - Ready for Review Ready for review by team code quality libcudf Affects libcudf (C++/CUDA) code. 4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 16, 2021
@codereport codereport self-assigned this Jun 16, 2021
@codereport codereport requested a review from a team as a code owner June 16, 2021 14:40
@codecov
Copy link

codecov bot commented Jun 16, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@468c573). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 9533966 differs from pull request most recent head af17212. Consider uploading reports for the commit af17212 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8534   +/-   ##
===============================================
  Coverage                ?   82.95%           
===============================================
  Files                   ?      109           
  Lines                   ?    18226           
  Branches                ?        0           
===============================================
  Hits                    ?    15120           
  Misses                  ?     3106           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 468c573...af17212. Read the comment docs.

@harrism harrism added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond labels Jun 16, 2021
@harrism
Copy link
Member

harrism commented Jun 16, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 716dc12 into rapidsai:branch-21.08 Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgsl888prabhu rgsl888prabhu rgsl888prabhu approved these changes

@harrism harrism harrism approved these changes

@jrhemstad jrhemstad Awaiting requested review from jrhemstad

Assignees

@codereport codereport

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codereport @harrism @rgsl888prabhu