-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added optional flag for building Arrow with S3 filesystem support #8531
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Java approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens when S3 is disabled and arrow_io_source
is called with an S3 backed URI? Should we have a test that we get the expected exception and don't crash?
In that case https://github.com/rapidsai/cudf/blob/branch-21.08/cpp/include/cudf/io/datasource.hpp#L321 would trigger. Always good to add a test however. |
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8531 +/- ##
=============================================
Coverage 82.57% 82.57%
=============================================
Files 109 109
Lines 17870 17870
=============================================
Hits 14757 14757
Misses 3113 3113 Continue to review full report at Codecov.
|
@gpucibot merge |
Added the cmake build flag
CUDF_ENABLE_ARROW_S3
to conditionally build Arrow with S3 filesystem support. By default support for S3 filesystem will be enabled. If S3 support needs to be disabled you can pass-DCUDF_ENABLE_ARROW_S3=OFF