Properly retrieve last column when -1 is specified for column index
#8529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isVoid
added
3 - Ready for Review
shwina
approved these changes
Jun 16, 2021
charlesbluca
approved these changes
Jun 16, 2021
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8529 +/- ##
===============================================
Coverage ? 82.95%
===============================================
Files ? 109
Lines ? 18226
Branches ? 0
===============================================
Hits ? 15120
Misses ? 3106
Partials ? 0 Continue to review full report at Codecov.
|
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8501
This PR fixes the bug when indexing columns with -1 in
column_acccessor.select_by_index, the last column is not properly retrieved.