Correct unused parameter warnings in transform and unary ops #8521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
libcudf
codereport
approved these changes
Jun 15, 2021
| std::enable_if_t<!cudf::is_fixed_width<T>() && !std::is_same<T, string_view>::value && | ||
| !std::is_same<T, list_view>::value && !std::is_same<T, struct_view>::value, | ||
| void> | ||
| operator()(Args&&...) |
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8521 +/- ##
===============================================
Coverage ? 82.60%
===============================================
Files ? 109
Lines ? 17841
Branches ? 0
===============================================
Hits ? 14737
Misses ? 3104
Partials ? 0 Continue to review full report at Codecov.
|
…nsform_and_unary_ops
|
@gpucibot merge |
robertmaynard
deleted the
bug/correct_unused_parameters_in_transform_and_unary_ops
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in CUDA 11.3, nvcc will start to unconditionally warn about unused parameters on functions/methods that are in anonymous namespaces.
This corrects issues found by this warning in transform and unary op algorithms