Fix offset of the string dictionary length stream #8515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuule
requested review from
harrism,
davidwendt,
shwina,
charlesbluca and
rgsl888prabhu
rgsl888prabhu
approved these changes
Jun 15, 2021
charlesbluca
approved these changes
Jun 15, 2021
Added a few comments, hopefully they are helpful in understanding the layout. |
davidwendt
approved these changes
Jun 15, 2021
vuule
added
5 - Ready to Merge
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8515 +/- ##
===============================================
Coverage ? 82.95%
===============================================
Files ? 110
Lines ? 18181
Branches ? 0
===============================================
Hits ? 15082
Misses ? 3099
Partials ? 0 Continue to review full report at Codecov.
|
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8514
String dictionary length is RLE encoded and
rle_data_sizeandnon_rle_data_sizetake this into account. However, When computing chunk stream offsets, these streams were treated as non-RLE andnon_rle_data_sizewas not added. This caused discrepancy between non-RLE stream sizes and available space, leading to overlap between chunk streams.Applied the
non_rle_data_sizeto the offset to correct the discrepancy and added a test that uses decimal columns to increase the size of non-RLE encoded data and enable the overflow.