Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in JNI APIs for scan, replace_nulls, group_by.scan, and group_by.replace_nulls [skip ci] #8503

Merged
merged 7 commits into from
Jun 24, 2021

Conversation

revans2
Copy link
Contributor

@revans2 revans2 commented Jun 11, 2021

To be able to do a running window test prototype I added in APIs for scan, group_by.scan, and group_by.replace_nulls. I also added a version of replace_nulls that java was missing. It is still not decided exactly how we are going to support running windows, but I thought I should get these in in case we do want to use them.

@revans2 revans2 added 3 - Ready for Review Ready for review by team Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS 4 - Needs cuDF (Java) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 11, 2021
@revans2 revans2 self-assigned this Jun 11, 2021
@revans2 revans2 requested a review from a team as a code owner June 11, 2021 19:17
@github-actions github-actions bot added the CMake CMake build issue label Jun 11, 2021
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup for prefix sum! Looks good to me, just minor nits.

* Output values 1, 3, 6
* This currently only works for long values that are not nullable as this is currently a
* very simple implementation. It may be expanded in the future if needed.
* This is just a convenience method for an inclusive scan ona SUM.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* This is just a convenience method for an inclusive scan ona SUM.
* This is just a convenience method for an inclusive scan on a SUM.

package ai.rapids.cudf;

/*
* This is analogous to the native 'scan_type'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: It would be nice to define the semantics of inclusive vs. exclusive here.

package ai.rapids.cudf;

/*
* This is analogous to the native 'replace_policy'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: It would be nice to define the semantics of the values here for the Java devs that don't want to dive into the native code.

@revans2
Copy link
Contributor Author

revans2 commented Jun 24, 2021

@jlowe I think I have addressed all of your review comments, and updated the comments for a few other Enums too, because I was following a pattern that was already there.

@revans2
Copy link
Contributor Author

revans2 commented Jun 24, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 11e021d into rapidsai:branch-21.08 Jun 24, 2021
@revans2 revans2 deleted the jni_scan branch June 24, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants