-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in JNI APIs for scan, replace_nulls, group_by.scan, and group_by.replace_nulls [skip ci] #8503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup for prefix sum! Looks good to me, just minor nits.
* Output values 1, 3, 6 | ||
* This currently only works for long values that are not nullable as this is currently a | ||
* very simple implementation. It may be expanded in the future if needed. | ||
* This is just a convenience method for an inclusive scan ona SUM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* This is just a convenience method for an inclusive scan ona SUM. | |
* This is just a convenience method for an inclusive scan on a SUM. |
package ai.rapids.cudf; | ||
|
||
/* | ||
* This is analogous to the native 'scan_type'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: It would be nice to define the semantics of inclusive vs. exclusive here.
package ai.rapids.cudf; | ||
|
||
/* | ||
* This is analogous to the native 'replace_policy'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: It would be nice to define the semantics of the values here for the Java devs that don't want to dive into the native code.
@jlowe I think I have addressed all of your review comments, and updated the comments for a few other Enums too, because I was following a pattern that was already there. |
@gpucibot merge |
To be able to do a running window test prototype I added in APIs for
scan
,group_by.scan
, andgroup_by.replace_nulls
. I also added a version ofreplace_nulls
that java was missing. It is still not decided exactly how we are going to support running windows, but I thought I should get these in in case we do want to use them.