-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow groupby aggs for StructColumns
#8499
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8499 +/- ##
===============================================
Coverage ? 82.91%
===============================================
Files ? 110
Lines ? 18094
Branches ? 0
===============================================
Hits ? 15002
Misses ? 3092
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch Charles, this looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @charlesbluca
@gpucibot merge |
@charlesbluca do you want to add a test for this as well ? |
Sure! I'll make sure we catch a |
Closes #8474
We were erroneously using the
_STRING_AGGS
set of allowed aggregations for struct dtypes ingroupby.pyx
, which allowed us to perform erroneous groupbys onStructColumns
; in @ayushdg's example:This change corrects this error, which should now prevent groupby operations on
StructColumns
.