Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/correct unused parameters in reshape and text #8495

Conversation

robertmaynard
Copy link
Contributor

Starting in CUDA 11.3, nvcc will start to unconditionally warn about unused parameters on functions/methods that are in anonymous namespaces.

This corrects issues found by this warning in reshape and text algorithms

@robertmaynard robertmaynard added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. tech debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 11, 2021
@robertmaynard robertmaynard requested a review from a team as a code owner June 11, 2021 11:57
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@90de10d). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 3ef42a6 differs from pull request most recent head 8262315. Consider uploading reports for the commit 8262315 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8495   +/-   ##
===============================================
  Coverage                ?   82.90%           
===============================================
  Files                   ?      110           
  Lines                   ?    18091           
  Branches                ?        0           
===============================================
  Hits                    ?    14998           
  Misses                  ?     3093           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90de10d...8262315. Read the comment docs.

@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@robertmaynard
Copy link
Contributor Author

rerun tests

@rapids-bot rapids-bot bot merged commit 533be36 into rapidsai:branch-21.08 Jun 14, 2021
@robertmaynard robertmaynard deleted the bug/correct_unused_parameters_in_reshape_and_text branch June 15, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants