Add JNI for strings::repeat_strings [skip ci]
#8491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttnghia
added
feature request
ttnghia
changed the title
strings::repeat_stringsstrings::repeat_strings [skip ci]
ttnghia
force-pushed
the
add_jni_repeat_strings
branch
from
2577d3d
to
23d1fe1
Compare
ttnghia
added
3 - Ready for Review
| * | ||
| * Note that this function cannot handle the cases when the size of the output column exceeds | ||
| * the maximum value that can be indexed by int type. In such situations, the output result | ||
| * is undefined. |
There was a problem hiding this comment.
interesting, could not we just repeat as many times as fit ?
There was a problem hiding this comment.
Bound check should be done on the plugin side to make sure the output is correct. I tried to implement bounds check in cudf C++ but was rejected.
revans2
approved these changes
Jun 11, 2021
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 26, 2021
…eparately by different numbers of times (#8572) This is a follow up work on #8491 so that cudf's `strings::repeat_strings` fully supports StringRepeat SQL expression in Apache Spark. This PR also rewrites some existing code, including re-formatting code and changes in doxygen. Authors: - Nghia Truong (https://github.com/ttnghia) Approvers: - Jason Lowe (https://github.com/jlowe) URL: #8572
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds JNI for
strings::repeat_strings.