Refactor index construction #8485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
2 - In Progress
vyasr
added
3 - Ready for Review
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8485 +/- ##
===============================================
Coverage ? 82.94%
===============================================
Files ? 109
Lines ? 18167
Branches ? 0
===============================================
Hits ? 15069
Misses ? 3098
Partials ? 0 Continue to review full report at Codecov.
|
|
rerun tests |
shwina
approved these changes
Jun 17, 2021
galipremsagar
approved these changes
Jun 17, 2021
galipremsagar
added
5 - Ready to Merge
|
rerun tests |
|
@gpucibot merge |
|
rerun tests |
1 similar comment
|
rerun tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #8309 allow us to avoid overriding
__new__for all index types and instead use the more standard__init__, which also makes it easier to share logic between different index classes via typical inheritance patterns.