Correct unused parameter warnings in replace algorithms #8483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8483 +/- ##
===============================================
Coverage ? 82.85%
===============================================
Files ? 109
Lines ? 17926
Branches ? 0
===============================================
Hits ? 14853
Misses ? 3073
Partials ? 0 Continue to review full report at Codecov.
|
karthikeyann
approved these changes
Jun 11, 2021
|
@gpucibot merge |
cwharris
reviewed
Jun 11, 2021
| @@ -367,7 +366,7 @@ std::unique_ptr<cudf::column> replace_nulls_scalar_kernel_forwarder::operator()< | |||
| std::unique_ptr<cudf::column> replace_nulls_policy_impl(cudf::column_view const& input, | |||
| cudf::replace_policy const& replace_policy, | |||
| rmm::cuda_stream_view stream, | |||
| rmm::mr::device_memory_resource* mr) | |||
| rmm::mr::device_memory_resource*) | |||
There was a problem hiding this comment.
this is a bug. we should be using the provided mr to allocate the return value.
There was a problem hiding this comment.
Yea, it should be propagated down to the cudf::detail::gather call. I will open a PR that fixes this issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in CUDA 11.3, nvcc will start to unconditionally warn about unused parameters on functions/methods that are in anonymous namespaces.