Update minimum Dask requirement to 2021.6.0 #8458
Conversation
|
In this PR are you trying to change the dev environments, the releases, nightlies, or all three ? Note that for CI testing we do not use any pins: |
|
All three, that's because we need to ensure package versions, whereas CI is installing from source. |
|
The last two releases we've been pinning a maximum version of dask/distributed. When we get to the 21.08 we will probably need to change things to restrict to a new maximum |
|
Right, but 21.08 is still unreleased, do we want to pin to a max version during development? |
|
We could also just pin to this Dask + Distributed release for now and slowly relax that as new releases come out |
|
I think it's ok to unpin during development. But I think it would be good to hear from @galipremsagar and/or @shwina |
|
Should be fine to unpin during development. |
|
We'll need |
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8458 +/- ##
===============================================
Coverage ? 82.84%
===============================================
Files ? 109
Lines ? 17913
Branches ? 0
===============================================
Hits ? 14840
Misses ? 3073
Partials ? 0 Continue to review full report at Codecov.
|
|
If we merged this PR while we waited for the integration repo issue to be resolved what would happen ? Nightly Docker Images would still be broken ? Anything else ? |
My understanding is this will unblock at least those environments that don't necessarily depend on other packages that may encounter the same type of issue this PR is trying to solve. I'm not sure what would happen to the Docker images, but I think this shouldn't introduce any new issues. With the above said, should we merge this? We have several approvals, but it's not entirely clear to me if we should hold until integration creates branch-21.08. |
|
|
galipremsagar
removed
the
5 - DO NOT MERGE
|
rerun tests |
|
@gpucibot merge |
…s, update dependencies (#3968) * Updates dask/distributed versions to match cuDF (rapidsai/cudf#8458) * Updates to Thrust v1.12.0 to align with cuDF and cuGraph * Don't include the src and src_prims directories in `cuml::cuml++` target's public include paths * Add missing `<cstddef>` and `<cstdint>` include directives * Promote `trustworthiness_score` to public `cuml/metrics/metrics.hpp` header and update Cython * Compile Cython with `-std=c++17` * Remove `-Wstrict-prototypes` Cython warning * Fixes linker error in debug builds * Fixes #3885 Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) - AJ Schmidt (https://github.com/ajschmidt8) URL: #3968
…s, update dependencies (rapidsai#3968) * Updates dask/distributed versions to match cuDF (rapidsai/cudf#8458) * Updates to Thrust v1.12.0 to align with cuDF and cuGraph * Don't include the src and src_prims directories in `cuml::cuml++` target's public include paths * Add missing `<cstddef>` and `<cstdint>` include directives * Promote `trustworthiness_score` to public `cuml/metrics/metrics.hpp` header and update Cython * Compile Cython with `-std=c++17` * Remove `-Wstrict-prototypes` Cython warning * Fixes linker error in debug builds * Fixes rapidsai#3885 Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) - AJ Schmidt (https://github.com/ajschmidt8) URL: rapidsai#3968
We need Dask >= 2021.6.0 to resolve the
make_metaissue fixed in dask/dask#7743 , thus updating minimum Dask/Distributed requirement.Fixes #8457