Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failures when performing binary operations on DataFrames with empty columns #8452

Merged
merged 6 commits into from
Jul 20, 2021
Merged

Fix failures when performing binary operations on DataFrames with empty columns #8452

merged 6 commits into from
Jul 20, 2021

Conversation

ChrisJar
Copy link
Contributor

@ChrisJar ChrisJar commented Jun 7, 2021

Closes #8434

@ChrisJar ChrisJar requested a review from a team as a code owner June 7, 2021 21:26
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jun 7, 2021
@codecov
Copy link

codecov bot commented Jun 8, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@b011299). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head e4e6395 differs from pull request most recent head 3e59d12. Consider uploading reports for the commit 3e59d12 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8452   +/-   ##
===============================================
  Coverage                ?   10.49%           
===============================================
  Files                   ?      116           
  Lines                   ?    18581           
  Branches                ?        0           
===============================================
  Hits                    ?     1951           
  Misses                  ?    16630           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b011299...3e59d12. Read the comment docs.

@marlenezw marlenezw added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 9, 2021
galipremsagar
galipremsagar requested changes Jun 14, 2021
View reviewed changes
python/cudf/cudf/core/series.py Outdated Show resolved Hide resolved
@galipremsagar galipremsagar added the 0 - Waiting on Author Waiting for author to respond to review label Jun 14, 2021
@beckernick
Copy link
Member

@ChrisJar is this on target for 21.08 or should we push to 21.10?

@ChrisJar
Copy link
Contributor Author

Yep! This is still on track I'm just finishing up some refactoring that should be done by this afternoon

@galipremsagar galipremsagar removed the 0 - Waiting on Author Waiting for author to respond to review label Jul 20, 2021
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jul 20, 2021
@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5e0e9a3 into rapidsai:branch-21.08 Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesbluca charlesbluca charlesbluca approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@marlenezw marlenezw Awaiting requested review from marlenezw

@skirui-source skirui-source Awaiting requested review from skirui-source

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Binary operations on DataFrames and Series with empty columns fail
5 participants
@ChrisJar @beckernick @galipremsagar @charlesbluca @marlenezw