Add cudf::strings::integer_to_hex convert API #8450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
feature request
davidwendt
requested review from
karthikeyann,
ttnghia,
marlenezw and
skirui-source
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8450 +/- ##
================================================
+ Coverage 82.53% 82.91% +0.38%
================================================
Files 110 110
Lines 17739 18094 +355
================================================
+ Hits 14640 15002 +362
+ Misses 3099 3092 -7
Continue to review full report at Codecov.
|
ttnghia
approved these changes
Jun 8, 2021
marlenezw
approved these changes
Jun 9, 2021
|
ready to merge |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3105
This PR adds the
cudf::strings::integers_to_hexAPI to libcudf. Also, adds gtests for testing with all integer types. The PR also includes Cython updates to make the new API available to Python cudf.