Create objects from iterables that contain cudf.NA #8442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandon-b-miller
added
feature request
marlenezw
reviewed
Jun 7, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8442 +/- ##
===============================================
Coverage ? 83.89%
===============================================
Files ? 109
Lines ? 19636
Branches ? 0
===============================================
Hits ? 16473
Misses ? 3163
Partials ? 0 Continue to review full report at Codecov.
|
brandon-b-miller
added
3 - Ready for Review
marlenezw
approved these changes
Jun 9, 2021
isVoid
approved these changes
Jun 10, 2021
|
rerun tests |
brandon-b-miller
added
5 - Ready to Merge
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8287
PyArrow knows how to handle the
pd.NAsingleton and knows it represents nulls iffrom_pandas=Trueduring array construction. There's not an option to choose what sentinel or value is used to represent null however and the 'detection' of which values are exactly this object is implemented at the c++ level in pyarrow, limiting our options for 'tricking' pyarrow into seeingcudf.NAas null.As such it is probably best that our
NAbe identically the pandasNA. This also makescudf.NA is pd.NAreturn true, which is probably what we want as well.