JNI bindings for sort_lists [skip ci] #8439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sperlingxx <[email protected]>
Signed-off-by: sperlingxx <[email protected]>
sperlingxx
added
feature request
jlowe
approved these changes
Jun 4, 2021
| @@ -3045,11 +3045,13 @@ void testWindowingCollectList() { | |||
|
|
|||
| @Test | |||
| void testWindowingCollectSet() { | |||
| // TODO: Add test cases for aggCollectWithUnEqNulls and aggCollectWithEqNaNs after | |||
| // the issue (https://github.com/rapidsai/cudf/issues/8405) being addressed. | |||
There was a problem hiding this comment.
For the future, I'm not a fan of lumping a bunch of unrelated changes into a PR. These two changes are completely orthogonal and should have been done as separate PRs. It's not like the overhead of a separate PR is that high, especially since the Java PRs are skipping CI.
There was a problem hiding this comment.
Sorry, I will be aware of this in next time.
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to provide JNI wrapper for `cudf::lists::sort_lists', which sorts each row inside list_column. This feature is required by NVIDIA/spark-rapids#2557.
In addition, this PR also update comments and tests on NaNEquality/NullEquality of rolling_collect_set.