Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace make_empty_strings_column with make_empty_column #8435

Merged

Conversation

davidwendt
Copy link
Contributor

Closes #8352

This PR replaces the cudf::strings::detail::make_empty_strings_column call with the existing cudf::make_empty_column(cudf::data_type{cudf::type_id::STRING}) instead.

This allowed also removing the include of cudf/strings/detail/utilities.hpp from some source files as well.

No function has changed. The make_empty_strings_column detail utility is removed.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 3, 2021
@davidwendt davidwendt self-assigned this Jun 3, 2021
@davidwendt davidwendt requested a review from a team as a code owner June 3, 2021 19:59
@ttnghia
Copy link
Contributor

ttnghia commented Jun 3, 2021

I wonder why don't we call make_empty_column(cudf::type_id) instead of make_empty_column(cudf::data_type{cudf::type_id})?

@galipremsagar
Copy link
Contributor

rerun tests

Copy link
Contributor

@codereport codereport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@ad6e0bd). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8435   +/-   ##
===============================================
  Coverage                ?   82.83%           
===============================================
  Files                   ?      109           
  Lines                   ?    17901           
  Branches                ?        0           
===============================================
  Hits                    ?    14828           
  Misses                  ?     3073           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad6e0bd...318ef30. Read the comment docs.

@harrism
Copy link
Member

harrism commented Jun 8, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2ce0835 into rapidsai:branch-21.08 Jun 8, 2021
@davidwendt davidwendt deleted the remove-make-empty-strings branch June 8, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Remove stream and memory resource parameters from make_empty_strings_column
5 participants