Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JNI bindings for get_element [skip ci] #8433

Merged
merged 2 commits into from
Jun 3, 2021

Conversation

revans2
Copy link
Contributor

@revans2 revans2 commented Jun 3, 2021

Just like it says JNI bindings for get_element

@revans2 revans2 added Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS 4 - Needs cuDF (Java) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 3, 2021
@revans2 revans2 self-assigned this Jun 3, 2021
@revans2 revans2 requested a review from a team as a code owner June 3, 2021 17:05
/**
* Get a single item from the column at the specified index as a Scalar.
*
* Be careful. This is expensive and my involve running a kernel to copy the data out.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Be careful. This is expensive and my involve running a kernel to copy the data out.
* Be careful. This is expensive and may involve running a kernel to copy the data out.

@revans2
Copy link
Contributor Author

revans2 commented Jun 3, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0712ffa into rapidsai:branch-21.08 Jun 3, 2021
@revans2 revans2 deleted the jni_get_element branch June 3, 2021 21:13
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants