Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null_equality config of rolling_collect_set #8415

Merged
merged 6 commits into from
Jun 3, 2021
Merged

Fix null_equality config of rolling_collect_set #8415

merged 6 commits into from
Jun 3, 2021

Conversation

sperlingxx
Copy link
Contributor

Fix #8405, and add some tests for various null_equality and nan_equality.

@sperlingxx
fix rolling_collect_set
b7b2bf3 
Signed-off-by: sperlingxx <[email protected]>
@sperlingxx sperlingxx requested a review from ttnghia June 1, 2021 10:13
@sperlingxx sperlingxx requested a review from a team as a code owner June 1, 2021 10:13
@sperlingxx sperlingxx requested a review from devavret June 1, 2021 10:13
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jun 1, 2021
@sperlingxx sperlingxx added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change bug Something isn't working labels Jun 1, 2021
@sperlingxx sperlingxx requested a review from mythrocks June 1, 2021 10:16
ttnghia
ttnghia requested changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@ttnghia ttnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please check and fix other comments as I may miss something.

cpp/tests/groupby/collect_set_tests.cpp Outdated Show resolved Hide resolved
cpp/tests/groupby/collect_set_tests.cpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 1, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@c2ec012). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8415   +/-   ##
===============================================
  Coverage                ?   82.83%           
===============================================
  Files                   ?      109           
  Lines                   ?    17901           
  Branches                ?        0           
===============================================
  Hits                    ?    14828           
  Misses                  ?     3073           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2ec012...0e665b0. Read the comment docs.

@harrism
Copy link
Member

harrism commented Jun 2, 2021

We are code frozen. Can this wait for 21.08?

@GaryShen2008
Copy link
Contributor

@sperlingxx Let's target to 21.08.

@sperlingxx sperlingxx changed the base branch from branch-21.06 to branch-21.08 June 2, 2021 06:11
mythrocks
mythrocks approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. The only gripe I have is that the rolling/collect_ops_test.cpp does not specifically have a test for nan_equality, like you have added for groupby. :]

@sperlingxx
Copy link
Contributor Author

This looks good. The only gripe I have is that the rolling/collect_ops_test.cpp does not specifically have a test for nan_equality, like you have added for groupby. :]

I added it. Thanks for catching that :)

@sperlingxx
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d8fbb19 into rapidsai:branch-21.08 Jun 3, 2021
@sperlingxx sperlingxx deleted the fix_rolling_collect_set branch June 3, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@mythrocks mythrocks mythrocks approved these changes

@devavret devavret Awaiting requested review from devavret

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] null_equality config of rolling_collect_set doesn't work
5 participants
@sperlingxx @harrism @GaryShen2008 @mythrocks @ttnghia