Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement reverse in libcudf #8410

Merged
merged 26 commits into from
Jun 16, 2021
Merged

Implement reverse in libcudf #8410

merged 26 commits into from
Jun 16, 2021

Conversation

shaneding
Copy link
Contributor

Closes #7967

@shaneding shaneding changed the base branch from branch-21.06 to branch-21.08 May 31, 2021 22:21
@github-actions github-actions bot added Python Affects Python cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels May 31, 2021
@harrism
Copy link
Member

harrism commented May 31, 2021

To pass the style failure, you just need to add reverse.hpp to the file cudf/conda/recipes/libcudf/meta.yaml (please add it in alphabetical order).

<     - test -f $PREFIX/include/cudf/detail/reverse.hpp

@github-actions github-actions bot added the conda label Jun 1, 2021
@github-actions github-actions bot added the CMake CMake build issue label Jun 2, 2021
@codecov
Copy link

codecov bot commented Jun 4, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@884f98f). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 4d15447 differs from pull request most recent head 620bcee. Consider uploading reports for the commit 620bcee to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8410   +/-   ##
===============================================
  Coverage                ?   82.94%           
===============================================
  Files                   ?      110           
  Lines                   ?    18186           
  Branches                ?        0           
===============================================
  Hits                    ?    15084           
  Misses                  ?     3102           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 884f98f...620bcee. Read the comment docs.

@shaneding shaneding marked this pull request as ready for review June 4, 2021 19:46
@shaneding shaneding requested review from a team as code owners June 4, 2021 19:46
@shaneding shaneding marked this pull request as draft June 4, 2021 19:47
@github-actions github-actions bot removed the conda label Jun 8, 2021
@harrism harrism mentioned this pull request Jun 9, 2021
Closed
@hyperbolic2346
Copy link
Contributor

This looks good to me. I thought that we might want a gather map version of this since we seem to be moving towards gather maps, but the map is so trivial I don't see the value for it.

hyperbolic2346
hyperbolic2346 approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@hyperbolic2346 hyperbolic2346 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the naming thing is sorted I think this is fine to go.

harrism
harrism requested changes Jun 10, 2021
View reviewed changes
cpp/tests/copying/reverse_tests.cpp Outdated Show resolved Hide resolved
cpp/tests/copying/reverse_tests.cpp Outdated Show resolved Hide resolved
harrism
harrism requested changes Jun 14, 2021
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just noticed some test loops and vector<bool> that can be cleaned up. Regarding "no raw loops", recommend this talk: https://www.youtube.com/watch?v=qH6sSOr-yk8

cpp/tests/copying/reverse_tests.cpp Outdated Show resolved Hide resolved
cpp/tests/copying/reverse_tests.cpp Outdated Show resolved Hide resolved
cpp/tests/copying/reverse_tests.cpp Outdated Show resolved Hide resolved
cpp/tests/copying/reverse_tests.cpp Outdated Show resolved Hide resolved
cpp/tests/copying/reverse_tests.cpp Outdated Show resolved Hide resolved
harrism
harrism approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look great!

@harrism harrism added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jun 15, 2021
@quasiben
Copy link
Member

rerun tests

1 similar comment
@galipremsagar
Copy link
Contributor

rerun tests

@shaneding
Copy link
Contributor Author

@gpucibot merge

1 similar comment
@harrism
Copy link
Member

harrism commented Jun 16, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 93ce6c7 into rapidsai:branch-21.08 Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhemstad jrhemstad jrhemstad left review comments

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@hyperbolic2346 hyperbolic2346 hyperbolic2346 approved these changes

@shwina shwina shwina approved these changes

@harrism harrism harrism approved these changes

@trxcllnt trxcllnt trxcllnt approved these changes

@skirui-source skirui-source Awaiting requested review from skirui-source

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Request a cudf function for reverse
10 participants
@shaneding @harrism @shwina @hyperbolic2346 @quasiben @galipremsagar @trxcllnt @ajschmidt8 @jrhemstad @brandon-b-miller