Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark for strings/integers convert APIs #8402

Merged

Conversation

davidwendt
Copy link
Contributor

Reference #5698
This PR adds benchmark tests for cudf::strings::to_integers and cudf::strings::from_integers. The current convert_floats_benchmark.cpp was refactored to work with floats and integer types and changed to convert_numerics_benchmark.cpp

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 28, 2021
@davidwendt davidwendt self-assigned this May 28, 2021
@davidwendt davidwendt requested a review from a team as a code owner May 28, 2021 16:59
@github-actions github-actions bot added the CMake CMake build issue label May 28, 2021
@harrism harrism added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Jun 2, 2021
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@606d854). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8402   +/-   ##
===============================================
  Coverage                ?   82.83%           
===============================================
  Files                   ?      109           
  Lines                   ?    17901           
  Branches                ?        0           
===============================================
  Hits                    ?    14828           
  Misses                  ?     3073           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 606d854...547b293. Read the comment docs.

@harrism
Copy link
Member

harrism commented Jun 2, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1ba59bd into rapidsai:branch-21.08 Jun 2, 2021
@davidwendt davidwendt deleted the benchmark-strings-integers branch June 2, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants