Handle pre-sliced nested columns in contiguous_split. #8391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly handled for nested types.
nvdbaranec
added
bug
github-actions
bot
added
CMake
nvdbaranec
requested review from
mythrocks
and removed request for
a team and
robertmaynard
ttnghia
approved these changes
May 28, 2021
|
rerun tests |
devavret
approved these changes
May 31, 2021
mythrocks
approved these changes
Jun 2, 2021
|
Rerun tests. |
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8391 +/- ##
===============================================
Coverage ? 82.91%
===============================================
Files ? 110
Lines ? 18094
Branches ? 0
===============================================
Hits ? 15002
Misses ? 3092
Partials ? 0 Continue to review full report at Codecov.
|
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The computation that applied offsets down a hierarchy of nested columns was starting with the wrong base offset in the case of nested columns.
Note: marking as Do Not Merge for the time being so it gets some more non-CI testing. Specifically: this PR #8153