-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation fix: Remove redefinition for std::is_same_v()
#8369
Conversation
Failure seems transient, and unrelated to the change:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, update copyright.
@gpucibot merge |
rerun tests |
Argh! Sorry I missed the copyright. Any objection to my pushing a fix to this? |
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #8369 +/- ##
===============================================
Coverage ? 82.86%
===============================================
Files ? 106
Lines ? 17874
Branches ? 0
===============================================
Hits ? 14811
Misses ? 3063
Partials ? 0 Continue to review full report at Codecov.
|
Thanks for the reviews, all. |
With
nvcc-11.2
+gcc-10.2
, one sees the following compilation errors intype_list_tests.cpp
:I'm not sure why this doesn't turn up with
gcc-9
, even though we're using--std=c++17
on both.This commit removes the redefinition of
is_same_v()
.