Fix concatenate_lists_ignore_null on rows of all_nulls #8312
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the rework of
cudf::lists::concatenate_rows
, something changed on null handling failed corresponding cuDF Java tests.In specific, when we apply
concatenate_null_policy::IGNORE
, the output lists are always null free, even if input data contains rows consisting of all nulls.In my opinion, we had better creating null mask for input rows of
all_nulls
, to keep align with single column concatenate.Signed-off-by: sperlingxx [email protected]