Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added _is_homogeneous property #8299

Merged
merged 5 commits into from
May 24, 2021

Conversation

shaneding
Copy link
Contributor

This PR closes #7067.
This was implemented by adding the _is_homogeneous property to DataFrame. Included are appropriate test cases.

@shaneding shaneding requested a review from a team as a code owner May 20, 2021 19:59
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 20, 2021
@brandon-b-miller
Copy link
Contributor

thanks for adding this :) I realize now after having requested DataFrame._is_homogenous in the original issue that this property might be better suited for our Frame class so all our column based objects get it for free.

@shaneding
Copy link
Contributor Author

@brandon-b-miller no worries, I can move this to Frame easily.

@beckernick beckernick added non-breaking Non-breaking change feature request New feature or request labels May 20, 2021
@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@0ebf7e6). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 2ad2592 differs from pull request most recent head e9311bf. Consider uploading reports for the commit e9311bf to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #8299   +/-   ##
===============================================
  Coverage                ?   82.88%           
===============================================
  Files                   ?      105           
  Lines                   ?    17880           
  Branches                ?        0           
===============================================
  Hits                    ?    14820           
  Misses                  ?     3060           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ebf7e6...e9311bf. Read the comment docs.

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label May 21, 2021
@beckernick
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 3da0d12 into rapidsai:branch-21.06 May 24, 2021
@brandon-b-miller
Copy link
Contributor

great work @shaneding !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Internal python _is_homogeneous property
4 participants