Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Support creating a scalar from utf8 string [skip ci] #8294

Merged
merged 2 commits into from
May 20, 2021

Conversation

firestarman
Copy link
Contributor

@firestarman firestarman commented May 20, 2021

This is a small PR to support creating a scalar from an array of utf8 bytes.

Since the PR #8257 added the support for ColumnVector creation, so I think we'd better add it for scalar creation to avoid conversions between utf8 strings and Java strings when used in Spark.

Signed-off-by: Firestarman [email protected]

@firestarman firestarman requested a review from a team as a code owner May 20, 2021 08:17
@github-actions github-actions bot added the Java Affects Java cuDF API. label May 20, 2021
@firestarman firestarman added 3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS labels May 20, 2021
Signed-off-by: Firestarman <[email protected]>
Copy link
Contributor

@wbo4958 wbo4958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@firestarman firestarman added the 5 - Ready to Merge Testing and reviews complete, ready to merge label May 20, 2021
@firestarman
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 48647aa into rapidsai:branch-21.06 May 20, 2021
@firestarman firestarman deleted the scalar-utf8 branch May 20, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team 5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants