-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Java API for Concatenate strings with separator [skip ci] #8289
Conversation
Signed-off-by: Thomas Graves <[email protected]>
Signed-off-by: Thomas Graves <[email protected]>
Signed-off-by: Thomas Graves <[email protected]>
Signed-off-by: Thomas Graves <[email protected]>
Signed-off-by: Thomas Graves <[email protected]>
Signed-off-by: Thomas Graves <[email protected]>
Signed-off-by: Thomas Graves <[email protected]>
…list concatenate with scalar separator
Signed-off-by: Thomas Graves <[email protected]>
This reverts commit 93fba2a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me other than a minor nit about the parameter naming.
Note the last commit I pushed, if need be I can separate that out into another PR if 8285 doesn't get in quick enough. |
note the last test fix is put up in https://github.com/rapidsai/cudf/pull/8330/files |
The Prs this was depending on are all merged marking as ready for review. I'm also asynchronously upmerging and running tests once more. |
@gpucibot merge |
Add java api's to be able to call string concatenate with separators.
DO NOT MERGE until: #8285 and #8282 are merged. We need those changes for the API used in this PR as well as functionality to match what Spark needs.
new arguments were added to the existing concatenate api that takes a scalar for the separator, so I extended that. I added new api's for the concatenate api that takes a column as the separator. I also added new api's for both join_list_elements api's, one with scalar separator and one with column separator.