Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java API for Concatenate strings with separator [skip ci] #8289

Merged
merged 22 commits into from
May 26, 2021

Conversation

tgravescs
Copy link
Contributor

@tgravescs tgravescs commented May 19, 2021

Add java api's to be able to call string concatenate with separators.

DO NOT MERGE until: #8285 and #8282 are merged. We need those changes for the API used in this PR as well as functionality to match what Spark needs.

new arguments were added to the existing concatenate api that takes a scalar for the separator, so I extended that. I added new api's for the concatenate api that takes a column as the separator. I also added new api's for both join_list_elements api's, one with scalar separator and one with column separator.

@tgravescs tgravescs added feature request New feature or request 3 - Ready for Review Ready for review by team Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels May 19, 2021
@tgravescs tgravescs self-assigned this May 19, 2021
@tgravescs tgravescs requested a review from a team as a code owner May 19, 2021 22:02
java/src/main/java/ai/rapids/cudf/ColumnVector.java Outdated Show resolved Hide resolved
java/src/main/java/ai/rapids/cudf/ColumnVector.java Outdated Show resolved Hide resolved
java/src/main/java/ai/rapids/cudf/ColumnVector.java Outdated Show resolved Hide resolved
java/src/main/java/ai/rapids/cudf/ColumnVector.java Outdated Show resolved Hide resolved
java/src/main/java/ai/rapids/cudf/ColumnVector.java Outdated Show resolved Hide resolved
java/src/main/java/ai/rapids/cudf/ColumnVector.java Outdated Show resolved Hide resolved
java/src/main/java/ai/rapids/cudf/ColumnVector.java Outdated Show resolved Hide resolved
java/src/main/java/ai/rapids/cudf/ColumnVector.java Outdated Show resolved Hide resolved
java/src/main/native/src/ColumnVectorJni.cpp Outdated Show resolved Hide resolved
@jlowe jlowe marked this pull request as draft May 19, 2021 23:00
@jlowe
Copy link
Member

jlowe commented May 19, 2021

DO NOT MERGE until: #8285 and #8282 are merged.

Converted this to draft to prevent accidental merging even if approved.

Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me other than a minor nit about the parameter naming.

@tgravescs
Copy link
Contributor Author

Note the last commit I pushed, if need be I can separate that out into another PR if 8285 doesn't get in quick enough.

@tgravescs
Copy link
Contributor Author

note the last test fix is put up in https://github.com/rapidsai/cudf/pull/8330/files

@tgravescs
Copy link
Contributor Author

The Prs this was depending on are all merged marking as ready for review. I'm also asynchronously upmerging and running tests once more.

@tgravescs tgravescs marked this pull request as ready for review May 26, 2021 20:48
@tgravescs
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a29c0e3 into rapidsai:branch-21.06 May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team feature request New feature or request Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants