Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually test equality in assert_groupby_results_equal #8272

Merged
merged 2 commits into from
May 20, 2021
Merged

Actually test equality in assert_groupby_results_equal #8272

merged 2 commits into from
May 20, 2021

Conversation

shwina
Copy link
Contributor

@shwina shwina commented May 18, 2021

No description provided.

@shwina shwina requested a review from a team as a code owner May 18, 2021 16:16
@shwina shwina requested review from kkraus14 and isVoid May 18, 2021 16:16
@shwina shwina added bug Something isn't working Python Affects Python cuDF API. labels May 18, 2021
@shwina shwina added the non-breaking Non-breaking change label May 18, 2021
@kkraus14
Copy link
Collaborator

rerun tests

@isVoid isVoid mentioned this pull request May 20, 2021
Merged
@shwina
Copy link
Contributor Author

shwina commented May 20, 2021

rerun tests

@codecov
Copy link

codecov bot commented May 20, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@eb88a38). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #8272   +/-   ##
===============================================
  Coverage                ?   82.87%           
===============================================
  Files                   ?      105           
  Lines                   ?    17865           
  Branches                ?        0           
===============================================
  Hits                    ?    14805           
  Misses                  ?     3060           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb88a38...f1257b1. Read the comment docs.

@kkraus14
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 75e12d1 into rapidsai:branch-21.06 May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isVoid isVoid isVoid approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

@gerashegalov gerashegalov gerashegalov approved these changes

@cwharris cwharris cwharris approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shwina @kkraus14 @cwharris @gerashegalov @galipremsagar @isVoid