-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix struct binary search and struct flattening #8268
Fix struct binary search and struct flattening #8268
Conversation
… the children columns for null
…hould have the same null order as their parent column
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #8268 +/- ##
===============================================
Coverage ? 82.89%
===============================================
Files ? 105
Lines ? 17875
Branches ? 0
===============================================
Hits ? 14818
Misses ? 3057
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my perspective things look good. I have rerun tests and they pass.
@gpucibot merge |
This PR fixes several bugs. In particular:
Unit tests for struct binary search and struct sorting are also rewritten.
Closes #8189.