-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade dlpack to 0.5 #8262
upgrade dlpack to 0.5 #8262
Conversation
waiting for conda-forge to get updated with dlpack 0.5 so I can test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This resolves the errors I was seeing. Thanks @cwharris !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…pdgrade-dlpack-0.5
…pdgrade-dlpack-0.5
…stom_commands to print headers as part of build
Guessing this will eventually run into the Python test failures we are fixing in PR ( #8342 ). So this may need an admin merge (though probably worth waiting to make sure those are the only failures on CI) |
Looks like we're failing due to the errors which will be fixed by #8342 .
|
@kkraus14 Ok to do an admin merge here? |
Update dlpack from
0.3
to>=0.5,<0.6.0a0
, and fix for breaking changes introduced in0.4
.closes #7679