Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review] Correct unused parameter warnings in dictonary algorithms #8239

Conversation

robertmaynard
Copy link
Contributor

Starting in CUDA 11.3, nvcc will start to unconditionally warn about unused parameters on functions/methods that are in anonymous namespaces.

@robertmaynard robertmaynard requested a review from a team as a code owner May 13, 2021 20:20
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label May 13, 2021
@robertmaynard robertmaynard changed the title Correct unused parameter warnings in dictonary algorithms [Review] Correct unused parameter warnings in dictonary algorithms May 13, 2021
cpp/src/dictionary/search.cu Outdated Show resolved Hide resolved
cpp/src/dictionary/detail/concatenate.cu Outdated Show resolved Hide resolved
cpp/src/dictionary/set_keys.cu Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@8406522). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 7c3d0c9 differs from pull request most recent head 96de74e. Consider uploading reports for the commit 96de74e to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #8239   +/-   ##
===============================================
  Coverage                ?   82.89%           
===============================================
  Files                   ?      105           
  Lines                   ?    17938           
  Branches                ?        0           
===============================================
  Hits                    ?    14870           
  Misses                  ?     3068           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8406522...96de74e. Read the comment docs.

@robertmaynard robertmaynard added non-breaking Non-breaking change code quality 3 - Ready for Review Ready for review by team labels May 17, 2021
@robertmaynard robertmaynard force-pushed the bug/correct_unused_parameters_in_dictionary branch from c2d2ac3 to 96de74e Compare May 17, 2021 20:19
@robertmaynard robertmaynard added the improvement Improvement / enhancement to an existing function label May 17, 2021
@harrism
Copy link
Member

harrism commented May 17, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 975d22f into rapidsai:branch-21.06 May 18, 2021
@robertmaynard robertmaynard deleted the bug/correct_unused_parameters_in_dictionary branch May 18, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants