Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make gpuCI and pre-commit style configurations consistent #8215
Make gpuCI and pre-commit style configurations consistent #8215
Changes from 3 commits
2a7498a
1b1a7e3
8eab7ab
42ecf31
f2ad3b2
4cb923b
00ecc51
220a722
bdb23db
4bc7b69
c301e3f
6cead3b
a9f555e
d34eeb9
994e770
88eca4e
44399d3
1dc0d9b
ab166a0
ef6691c
bb622a9
323d3a5
02ab8e6
1655435
31a1a23
3e799bd
367e1cd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, the pre-commit hooks for
isort
automatically skip Cython files, while the CLI does not, so I had to specify to skip them here. Do we want package sorting for Cython files?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we can get Cython/PYI resorting in pre-commit's isort hook with:
So if we would like package resorting on Cython and/or module files it's now totally doable.