Add compiled binary operation #8192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solves is_constructible issue with nvcc custom class is not needed since __shared__ issue is fixed with time_point
karthikeyann
added
feature request
jrhemstad
requested changes
May 10, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8192 +/- ##
===============================================
Coverage ? 10.67%
===============================================
Files ? 109
Lines ? 18667
Branches ? 0
===============================================
Hits ? 1993
Misses ? 16674
Partials ? 0 Continue to review full report at Codecov.
|
karthikeyann
changed the title
jrhemstad
reviewed
Jul 6, 2021
jrhemstad
reviewed
Jul 6, 2021
jrhemstad
reviewed
Jul 6, 2021
cpp/src/binaryop/compiled/traits.hpp
Outdated
Comment on lines
23
to
30
| // has common type | ||
| template <typename AlwaysVoid, typename... Ts> | ||
| struct has_common_type_impl : std::false_type { | ||
| }; | ||
|
|
||
| template <typename... Ts> | ||
| struct has_common_type_impl<std::void_t<std::common_type_t<Ts...>>, Ts...> : std::true_type { | ||
| }; |
There was a problem hiding this comment.
detail namespace on these.
There was a problem hiding this comment.
done. moved few more *_impl into detail namespace.
jrhemstad
reviewed
Jul 7, 2021
ttnghia
approved these changes
Jul 12, 2021
jrhemstad
approved these changes
Jul 13, 2021
karthikeyann
added
5 - Ready to Merge
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add compiled binary operations (instead of jit).
(column_view lhs OP column_view rhs) => output_type
(scalar lhs OP column_view rhs) => output_type
(column_view lhs OP scalar rhs) => output_type
This PR adds compiled binary operations for fixed_width types.
string operations are already compiled.
Partially addresses #7801
Approach:
Each triple dispatcher compilation takes 60 seconds.
So, the device side dispatch is done in 2 ways.
common_type<Out, Lhs, Rhs>,single device side dispatch with nested individual type dispatch.Each operation compile time will be close to 30 seconds.
Adds ~4 minutes compilation time (ninja -j 12) (1.5 minutes for cu files, util.cpp takes 2.5 minutes)
Identifying common_type is done in host.
Operations functor is defined only for types supported.
and for operation not supported, no operation is done in device code.
- [ ]Coalesce, redirect Userdefined to jit.Unit tests:
It can't test all types. compilation time would be huge.
while, covering all valid combinations of types in all operations, while keeping it minimal.
Benchmark: