-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Implement .describe()
for DataFrameGroupBy
#8179
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8179 +/- ##
===============================================
Coverage ? 82.84%
===============================================
Files ? 109
Lines ? 17913
Branches ? 0
===============================================
Hits ? 14840
Misses ? 3073
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some tests for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have concerns regarding the use (and implementation) of assert_groupby_results_equal
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@gpucibot merge |
re-run tests |
This PR implements functionality to generate summary statistics for
Dataframe.groupby()
operationvia
.describe()
method, similar to Pandas.Fixes: #7990