-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Column refactoring 2 #8130
Column refactoring 2 #8130
Conversation
…e_column_duplication2
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #8130 +/- ##
===============================================
Coverage ? 82.85%
===============================================
Files ? 105
Lines ? 17891
Branches ? 0
===============================================
Hits ? 14823
Misses ? 3068
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, these extra helpers for binop bugged me for a while, nice work getting rid of them.
Co-authored-by: Keith Kraus <[email protected]>
@gpucibot merge |
Follow up to #8081. This PR 1) inlines the binary op functions in different columns (which I presume were mainly created for profiling with nvtx), 2) moves all categorical column concatenation logic into the CategoricalColumn class, which allows the deletion of certain unimplemented functions in ColumnBase that only existed to satisfy mypy, and 3) performs some cleanup in the form of removing unused properties and using the
cached_property
decorator where appropriate.