Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Reindex in DataFrame.__setitem__ #7957

Merged
merged 2 commits into from
Apr 16, 2021
Merged

[REVIEW] Reindex in DataFrame.__setitem__ #7957

merged 2 commits into from
Apr 16, 2021

Commits on Apr 14, 2021

  1. Reindex in DataFrame.__setitem__ (rapidsai#7948) 

    This PR fixes missing reindexing in `DataFrame.__setitem__` when the `value` argument is a `DataFrame`, we currently align index if `value` is a Series & `arg` is a column name already.

This change is necessary to continue with the upgrade to pandas `1.2.4`,  however pandas has confirmed this as a regression only in `1.2.0` and `1.2.2` hence corrected the pytest to only xfail in those versions of pandas.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Ashwin Srinath (https://github.com/shwina)

URL: rapidsai#7948
    @galipremsagar
    galipremsagar committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    f451fd6 View commit details
    Browse the repository at this point in the history

  2. pin max pandas to 1.2.4

    @galipremsagar
    galipremsagar committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    f1c48cd View commit details
    Browse the repository at this point in the history