Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add ability to extract include dirs from CUDF_HOME #7848

Merged
merged 1 commit into from
Apr 3, 2021
Merged

[REVIEW] Add ability to extract include dirs from CUDF_HOME #7848

merged 1 commit into from
Apr 3, 2021

Conversation

galipremsagar
Copy link
Contributor

This PR adds ability to extract include dirs during cythonization from CUDF_HOME.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 3, 2021
@galipremsagar galipremsagar self-assigned this Apr 3, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner April 3, 2021 01:57
@github-actions github-actions bot added the Python Affects Python cuDF API. label Apr 3, 2021
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Apr 3, 2021
@galipremsagar
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Apr 3, 2021 •
edited
Loading

Codecov Report

Merging #7848 (bce081b) into branch-0.19 (7871e7a) will increase coverage by 0.86%.
The diff coverage is n/a.

❗ Current head bce081b differs from pull request most recent head 7778f61. Consider uploading reports for the commit 7778f61 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7848      +/-   ##
===============================================
+ Coverage        81.86%   82.73%   +0.86%     
===============================================
  Files              101      103       +2     
  Lines            16884    17700     +816     
===============================================
+ Hits             13822    14644     +822     
+ Misses            3062     3056       -6
Impacted Files Coverage Δ
python/cudf/cudf/utils/dtypes.py 83.44% <0.00%> (-6.08%) ⬇️
python/cudf/cudf/utils/gpu_utils.py 53.65% <0.00%> (-4.88%) ⬇️
python/cudf/cudf/core/column/lists.py 87.32% <0.00%> (-4.08%) ⬇️
python/cudf/cudf/core/column/decimal.py 92.92% <0.00%> (-1.95%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 92.41% <0.00%> (-1.04%) ⬇️
python/cudf/cudf/utils/utils.py 85.36% <0.00%> (-0.07%) ⬇️
python/dask_cudf/dask_cudf/backends.py 89.58% <0.00%> (-0.05%) ⬇️
python/cudf/cudf/__init__.py 100.00% <0.00%> (ø)
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/core/__init__.py 100.00% <0.00%> (ø)
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b50016c...7778f61. Read the comment docs.

@kkraus14
Copy link
Collaborator

kkraus14 commented Apr 3, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 73638bb into rapidsai:branch-0.19 Apr 3, 2021
shwina pushed a commit to shwina/cudf that referenced this pull request Apr 7, 2021
@galipremsagar @shwina
Add ability to extract include dirs from CUDF_HOME (rapidsai#7848)
2729c7c 
This PR adds ability to extract `include` dirs during cythonization from `CUDF_HOME`.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Keith Kraus (https://github.com/kkraus14)

URL: rapidsai#7848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

@rgsl888prabhu rgsl888prabhu Awaiting requested review from rgsl888prabhu

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller

@trxcllnt trxcllnt Awaiting requested review from trxcllnt

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galipremsagar @kkraus14