Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't install Thrust examples, tests, docs, and python files #7811

Conversation

robertmaynard
Copy link
Contributor

Prune the amount of Thrust source tree that we install. On top of reducing the size of cudf's install tree, this fixes an
issue where when using cudf via conda-build, conda presumes that all python files inside cudf are valid and part of the package, and fails to parse them.

Prune the amount of Thrust source tree that we install. On top
of reducing the size of cudf's install tree, this fixes an
issue where when using cudf via conda-build, conda presumes that
all python files inside cudf are valid and part of the package, and fails
to parse them.
@robertmaynard robertmaynard requested a review from a team as a code owner April 1, 2021 13:43
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Apr 1, 2021
@kkraus14 kkraus14 added bug Something isn't working non-breaking Non-breaking change labels Apr 1, 2021
@kkraus14 kkraus14 added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Apr 1, 2021
@jakirkham
Copy link
Member

cc @harrism

@kkraus14
Copy link
Collaborator

kkraus14 commented Apr 1, 2021

@gpucibot merge

@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #7811 (ce72df3) into branch-0.19 (7871e7a) will increase coverage by 0.79%.
The diff coverage is n/a.

❗ Current head ce72df3 differs from pull request most recent head 52039ec. Consider uploading reports for the commit 52039ec to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7811      +/-   ##
===============================================
+ Coverage        81.86%   82.66%   +0.79%     
===============================================
  Files              101      103       +2     
  Lines            16884    17563     +679     
===============================================
+ Hits             13822    14518     +696     
+ Misses            3062     3045      -17     
Impacted Files Coverage Δ
python/cudf/cudf/utils/dtypes.py 83.44% <0.00%> (-6.08%) ⬇️
python/cudf/cudf/utils/gpu_utils.py 53.65% <0.00%> (-4.88%) ⬇️
python/cudf/cudf/core/column/lists.py 87.32% <0.00%> (-4.08%) ⬇️
python/cudf/cudf/core/column/decimal.py 92.68% <0.00%> (-2.19%) ⬇️
python/dask_cudf/dask_cudf/backends.py 87.50% <0.00%> (-2.13%) ⬇️
python/cudf/cudf/core/abc.py 87.23% <0.00%> (-1.14%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 92.77% <0.00%> (-0.68%) ⬇️
python/cudf/cudf/core/column/column.py 87.61% <0.00%> (-0.15%) ⬇️
python/cudf/cudf/utils/utils.py 85.36% <0.00%> (-0.07%) ⬇️
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 299f6cc...52039ec. Read the comment docs.

@rapids-bot rapids-bot bot merged commit b9415ca into rapidsai:branch-0.19 Apr 1, 2021
@robertmaynard robertmaynard deleted the bug/dont_install_thrust_python_files branch April 1, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants