Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Java explode outer unit tests [skip ci] #7782

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Fix Java explode outer unit tests [skip ci] #7782

merged 1 commit into from
Mar 31, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Mar 31, 2021

After #7754 the Java explode outer unit tests were not updated to expect the nulls.

@jlowe jlowe added bug Something isn't working Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer non-breaking Non-breaking change labels Mar 31, 2021
@jlowe jlowe self-assigned this Mar 31, 2021
@jlowe jlowe requested a review from a team as a code owner March 31, 2021 14:04
revans2
revans2 approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@revans2
Copy link
Contributor

revans2 commented Mar 31, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit be2f0c0 into rapidsai:branch-0.19 Mar 31, 2021
@jlowe jlowe deleted the fix-jni-explode-outer-tests branch September 10, 2021 15:46
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

Assignees

@jlowe jlowe

Labels
4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlowe @revans2 @vyasr