Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Java bindings to join gather map APIs [skip ci] #7751

Merged
merged 2 commits into from
Mar 30, 2021
Merged

Add Java bindings to join gather map APIs [skip ci] #7751

merged 2 commits into from
Mar 30, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Mar 29, 2021

Adds Java bindings for the libcudf join APIs that return gather maps. Depends upon #7454.

@jlowe jlowe added Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 29, 2021
@jlowe jlowe self-assigned this Mar 29, 2021
revans2
revans2 approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits.

java/src/main/java/ai/rapids/cudf/ColumnView.java Show resolved Hide resolved
java/src/main/java/ai/rapids/cudf/ColumnView.java Show resolved Hide resolved
java/src/main/java/ai/rapids/cudf/GatherMap.java Show resolved Hide resolved
java/src/main/java/ai/rapids/cudf/GatherMap.java Show resolved Hide resolved
java/src/main/java/ai/rapids/cudf/Table.java Show resolved Hide resolved
java/src/main/native/src/TableJni.cpp Show resolved Hide resolved
@jlowe jlowe marked this pull request as ready for review March 30, 2021 00:15
@jlowe jlowe requested a review from a team as a code owner March 30, 2021 00:15
@jlowe
Copy link
Member Author

jlowe commented Mar 30, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8188ddb into rapidsai:branch-0.19 Mar 30, 2021
@jlowe jlowe deleted the jni-join-gathermaps branch September 10, 2021 15:46
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

Assignees

@jlowe jlowe

Labels
4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlowe @revans2 @vyasr