-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dictionary size computation in ORC writer #7737
Merged
rapids-bot
merged 1 commit into
rapidsai:branch-0.19
from
vuule:bug-orc-writer-dictionary-cost
Mar 27, 2021
Merged
Fix dictionary size computation in ORC writer #7737
rapids-bot
merged 1 commit into
rapidsai:branch-0.19
from
vuule:bug-orc-writer-dictionary-cost
Mar 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #7661 |
vuule
added
bug
Something isn't working
non-breaking
Non-breaking change
cuIO
cuIO issue
labels
Mar 26, 2021
vuule
changed the title
Fix dictionary size computation error in ORC writer
Fix dictionary size computation in ORC writer
Mar 26, 2021
kaatish
approved these changes
Mar 27, 2021
rerun tests |
rgsl888prabhu
approved these changes
Mar 27, 2021
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7737 +/- ##
===============================================
+ Coverage 81.86% 82.52% +0.65%
===============================================
Files 101 101
Lines 16884 17458 +574
===============================================
+ Hits 13822 14407 +585
+ Misses 3062 3051 -11
Continue to review full report at Codecov.
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
5 - Ready to Merge
Testing and reviews complete, ready to merge
bug
Something isn't working
cuIO
cuIO issue
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7661
Corrects the field order in
std::accumulate
that computes the string column size w.r.t encoding.