Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decimal column comparison operations #7716

Merged
merged 17 commits into from
Apr 1, 2021
Merged

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Mar 25, 2021

Closes #7498

This PR adds binary comparison eq, lt, gt, le, ge to

  • decimal column v. decimal column
  • decimal column v. decimal scalar (decimal.Decimal and decimal cudf.Scalar)
  • decimal column v. integer column (cudf.utils.dtypes.INTEGER_TYPES)
  • decimal column v. integer scalar (Python ints)

Other minor adds:

@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 25, 2021
@isVoid isVoid self-assigned this Mar 25, 2021
@isVoid isVoid added 2 - In Progress Currently a work in progress feature request New feature or request non-breaking Non-breaking change labels Mar 25, 2021
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #7716 (f74b759) into branch-0.19 (7871e7a) will increase coverage by 0.80%.
The diff coverage is n/a.

❗ Current head f74b759 differs from pull request most recent head e8bfde2. Consider uploading reports for the commit e8bfde2 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7716      +/-   ##
===============================================
+ Coverage        81.86%   82.67%   +0.80%     
===============================================
  Files              101      103       +2     
  Lines            16884    17563     +679     
===============================================
+ Hits             13822    14520     +698     
+ Misses            3062     3043      -19     
Impacted Files Coverage Δ
python/cudf/cudf/utils/dtypes.py 83.54% <0.00%> (-5.97%) ⬇️
python/cudf/cudf/utils/gpu_utils.py 53.65% <0.00%> (-4.88%) ⬇️
python/cudf/cudf/core/column/lists.py 87.32% <0.00%> (-4.08%) ⬇️
python/cudf/cudf/core/column/decimal.py 92.68% <0.00%> (-2.19%) ⬇️
python/dask_cudf/dask_cudf/backends.py 87.50% <0.00%> (-2.13%) ⬇️
python/cudf/cudf/core/abc.py 87.23% <0.00%> (-1.14%) ⬇️
python/cudf/cudf/core/column/column.py 87.53% <0.00%> (-0.23%) ⬇️
python/cudf/cudf/utils/utils.py 85.36% <0.00%> (-0.07%) ⬇️
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 78.71% <0.00%> (ø)
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e379ab1...e8bfde2. Read the comment docs.

@isVoid isVoid requested a review from kkraus14 March 27, 2021 04:24
@isVoid isVoid marked this pull request as ready for review March 31, 2021 22:39
@isVoid isVoid requested a review from a team as a code owner March 31, 2021 22:39
@isVoid isVoid added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Mar 31, 2021
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Mar 31, 2021
@kkraus14
Copy link
Collaborator

@gpucibot merge

@harrism harrism changed the title Adds decimal column comparison operations Add decimal column comparison operations Mar 31, 2021
@rapids-bot rapids-bot bot merged commit 5f1dc79 into rapidsai:branch-0.19 Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Implement comparison operators for decimal columns
3 participants